linux-kernel - RE: [PATCH] gpio: xra1403: select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5P101MB0226C24A1E490246EC77B064E6F00@AM5P101MB0226.NAMP101.PROD.OUTLOOK.COM>
Date:   Tue, 30 May 2017 11:48:39 +0000
From:   "Han, Nandor (GE Healthcare)" <nandor.han@...com>
To:     Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] gpio: xra1403: select REGMAP_SPI



> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@...db.de]
> Sent: 30 May 2017 14:13
> To: Linus Walleij <linus.walleij@...aro.org>
> Cc: Han, Nandor (GE Healthcare) <nandor.han@...com>; Arnd Bergmann <arnd@...db.de>; linux-gpio@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: EXT: [PATCH] gpio: xra1403: select REGMAP_SPI
> 
> Without the regmap code, we get a link error:
> 
> drivers/gpio/built-in.o: In function `xra1403_probe':
> (.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
> 
> Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by:  Nandor Han <nandor.han@...com>

> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 66d1f353ca73..238fc231081a 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1241,6 +1241,7 @@ config GPIO_PISOSR
> 
>  config GPIO_XRA1403
>  	tristate "EXAR XRA1403 16-bit GPIO expander"
> +	select REGMAP_SPI
>  	help
>  	  GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander.
> 
> --
> 2.9.0