linux-kernel - Re: [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170530122003.scaw5f7diez7uhl6@dell>
Date:   Tue, 30 May 2017 13:20:03 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bin Gao <bin.gao@...el.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Subject: Re: [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver

On Tue, 30 May 2017, Andy Shevchenko wrote:

> On Tue, May 30, 2017 at 12:02 PM, Lee Jones <lee.jones@...aro.org> wrote:
> > On Tue, 23 May 2017, Hans de Goede wrote:
> 
> >> +static const struct i2c_device_id cht_wc_i2c_id[] = {
> >> +     { }
> >> +};
> >
> > What's the point in this empty table?
> 
> This is artifact of I2C framework, otherwise if will be not enumerated.
> 
> +Wolfram.
> 
> Wolfram, can we fix this? (In case we have either ACPI table or OF
> table there is no need to oblige providing empty legacy table)

I think I fixed this already.

Hint: `git grep probe_new -- drivers/i2c`

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog