linux-kernel - Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ef6cdbc-9a35-537d-d0f4-2d7cbb67ed59@c-s.fr>
Date:   Tue, 30 May 2017 14:46:45 +0200
From:   Christophe LEROY <christophe.leroy@....fr>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Scott Wood <oss@...error.net>,
        Balbir Singh <bsingharora@...il.com>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() on
 PPC32

Le 30/05/2017 à 12:50, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@....fr> writes:
> 
> ...
> 
> Please tell me why.

Because of patch https://patchwork.ozlabs.org/patch/766777/ which 
modifies patch_instruction() to use an alternative mapping.
Compilation fails on PPC32 because map_kernel_page() only exists on 
PPC64. However we have map_page() which does the same on PPC32, hence 
the renaming.

> 
> You also moved the declaration from mmu_decl.h to book3s/32/pgtable.h,
> but didn't update any includes, presumably we're confident everything
> gets pgtable.h somehow?

Yes I did that so that lib/code_patching.c sees it.
All users of map_page() already include pgtable in a way or another.

Christophe