linux-kernel - Re: [PATCH] platform/x86: intel_cht_int33fe: Set supplied-from property on max17047 dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 May 2017 16:22:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: intel_cht_int33fe: Set supplied-from
 property on max17047 dev

On Fri, May 26, 2017 at 1:53 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> Devices with the intel_cht_int33fe ACPI device use a max17047 fuel-gauge
> combined with a bq24272i charger, in order for the fuel-gauge driver to
> correctly display charging / discharging status it needs to know which
> charger is supplying the battery.
>
> This commit sets the supplied-from device property to the name of the
> bq24272i charger for this.

Pushed to testing, thanks!

>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/platform/x86/intel_cht_int33fe.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
> index 6a1b2ca5b6fe..da706e2c4232 100644
> --- a/drivers/platform/x86/intel_cht_int33fe.c
> +++ b/drivers/platform/x86/intel_cht_int33fe.c
> @@ -34,6 +34,13 @@ struct cht_int33fe_data {
>         struct i2c_client *pi3usb30532;
>  };
>
> +static const char * const max17047_suppliers[] = { "bq24190-charger" };
> +
> +static const struct property_entry max17047_props[] = {
> +       PROPERTY_ENTRY_STRING_ARRAY("supplied-from", max17047_suppliers),
> +       { }
> +};
> +
>  static int cht_int33fe_probe(struct i2c_client *client)
>  {
>         struct device *dev = &client->dev;
> @@ -70,6 +77,7 @@ static int cht_int33fe_probe(struct i2c_client *client)
>
>         memset(&board_info, 0, sizeof(board_info));
>         strlcpy(board_info.type, "max17047", I2C_NAME_SIZE);
> +       board_info.properties = max17047_props;
>
>         data->max17047 = i2c_acpi_new_device(dev, 1, &board_info);
>         if (!data->max17047)
> --
> 2.13.0
>



-- 
With Best Regards,
Andy Shevchenko