linux-kernel - Re: [PATCH] Input: s3c2410_ts - Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170530164845.GC12922@dtor-ws>
Date:   Tue, 30 May 2017 09:48:45 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     kgene@...nel.org, krzk@...nel.org, javier@....samsung.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: s3c2410_ts - Handle return value of
 clk_prepare_enable

On Tue, May 30, 2017 at 04:22:57PM +0530, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/s3c2410_ts.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index 41d58e8..3b3db8c 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -264,7 +264,11 @@ static int s3c2410ts_probe(struct platform_device *pdev)
>  		return -ENOENT;
>  	}
>  
> -	clk_prepare_enable(ts.clock);
> +	ret = clk_prepare_enable(ts.clock);
> +	if (ret) {
> +		dev_err(dev, "Failed! to enabled clocks\n");
> +		goto err_clk_get;
> +	}
>  	dev_dbg(dev, "got and enabled clocks\n");
>  
>  	ts.irq_tc = ret = platform_get_irq(pdev, 0);
> @@ -353,7 +357,9 @@ static int s3c2410ts_probe(struct platform_device *pdev)
>   err_iomap:
>  	iounmap(ts.io);
>   err_clk:
> +	clk_disable_unprepare(ts.clock);
>  	del_timer_sync(&touch_timer);
> + err_clk_get:
>  	clk_put(ts.clock);
>  	return ret;
>  }
> -- 
> 1.9.1
> 

-- 
Dmitry