linux-kernel - Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170530052920.GJ28017@X58A-UD3R>
Date:   Tue, 30 May 2017 14:29:20 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     <fweisbec@...il.com>, <peterz@...radead.org>, <mingo@...nel.org>,
        <rostedt@...dmis.org>
CC:     <linux-kernel@...r.kernel.org>, <kernel-team@....com>
Subject: Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use
 existing llist API

On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

+to peterz@...radead.org
+to mingo@...nel.org
+to rostedt@...dmis.org

I am not sure whom should I send this patch to..
Could you check this if you are right person?

> 
> Signed-off-by: Byungchul Park <byungchul.park@....com>
> ---
>  kernel/irq_work.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index bcf107c..e2ebe8c 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
>  		return;
>  
>  	llnode = llist_del_all(list);
> -	while (llnode != NULL) {
> -		work = llist_entry(llnode, struct irq_work, llnode);
> -
> -		llnode = llist_next(llnode);
> -
> +	llist_for_each_entry(work, llnode, llnode) {
>  		/*
>  		 * Clear the PENDING bit, after this point the @work
>  		 * can be re-used.
> -- 
> 1.9.1