linux-kernel - Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170530220951.GA9139@roeck-us.net>
Date:   Tue, 30 May 2017 15:09:51 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Joel Stanley <joel@....id.au>
Cc:     linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jaghathiswari Rankappagounder Natarajan <jaghu@...gle.com>
Subject: Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP

On Tue, May 30, 2017 at 03:48:22PM +0930, Joel Stanley wrote:
> On Sat, May 27, 2017 at 11:24 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> > The driver uses regmap and thus has to select it to avoid build
> > errors such as the following.
> >
> > drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
> >         'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type
> 
> While we're at it the driver should also depend on OF.
> 
The driver compiles without it, so that isn't strictly necessary.

> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> Acked-by: Joel Stanley <joel@....id.au>
> 
Thanks,

Guenter

> Cheers,
> 
> Joel
> 
> 
> > ---
> >  drivers/hwmon/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 22d5eafd6815..5ef2814345ef 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -343,6 +343,7 @@ config SENSORS_ASB100
> >
> >  config SENSORS_ASPEED
> >         tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> > +       select REGMAP
> >         help
> >           This driver provides support for ASPEED AST2400/AST2500 PWM
> >           and Fan Tacho controllers.
> > --
> > 2.7.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html