linux-kernel - Re: linux-next: build failure after merge of the rtc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 May 2017 07:45:07 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Lowe <dave-lowe@...world.com>
Subject: Re: linux-next: build failure after merge of the rtc tree

Am 31.05.2017 um 06:33 schrieb Stephen Rothwell:
> Hi Alexandre,
> 
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
> drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no member named 'client'
>    if (chip->alarm && (ds1307->client->irq > 0 ||
>                              ^
ds1307->client->irq would have to be replaced with ds1307->irq.
Same what the regmap patch does e.g. at line 1477.
The regmap patch removes member client from struct ds1307.

Rgds, Heiner

> 
> Caused by commit
> 
>   345b89453dda ("rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ")
> 
> interacting with commit
> 
>   11e5890b5342 ("rtc: ds1307: convert driver to regmap")
> 
> I have used the rtc tree from next-20170530 for today.
>