lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 May 2017 01:15:06 -0700 From: Tahsin Erdogan <tahsin@...gle.com> To: Jan Kara <jack@...e.com>, Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Dave Kleikamp <shaggy@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>, Mark Fasheh <mfasheh@...sity.com>, Joel Becker <jlbec@...lplan.org>, Jens Axboe <axboe@...com>, Deepa Dinamani <deepa.kernel@...il.com>, Mike Christie <mchristi@...hat.com>, Fabian Frederick <fabf@...net.be>, linux-ext4@...r.kernel.org Cc: linux-kernel@...r.kernel.org, jfs-discussion@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org, ocfs2-devel@....oracle.com, reiserfs-devel@...r.kernel.org, Tahsin Erdogan <tahsin@...gle.com> Subject: [PATCH 17/28] ext4: fix credits calculation for xattr inode When there is no space for a value in xattr block, it may be stored in an xattr inode even if the value length is less than EXT4_XATTR_MIN_LARGE_EA_SIZE(). So the current assumption in credits calculation is wrong. Signed-off-by: Tahsin Erdogan <tahsin@...gle.com> --- fs/ext4/xattr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 739f73a5a345..dcf7ec98f138 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1590,8 +1590,7 @@ ext4_xattr_set(struct inode *inode, int name_index, const char *name, if (error) return error; - if ((value_len >= EXT4_XATTR_MIN_LARGE_EA_SIZE(sb->s_blocksize)) && - ext4_has_feature_ea_inode(sb)) { + if (ext4_has_feature_ea_inode(sb)) { int nrblocks = (value_len + sb->s_blocksize - 1) >> sb->s_blocksize_bits; -- 2.13.0.219.gdb65acc882-goog
Powered by blists - more mailing lists