linux-kernel - Re: [HMM 06/15] mm/memory_hotplug: introduce add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170531113104.006dfc7e@firefly.ozlabs.ibm.com>
Date:   Wed, 31 May 2017 11:31:04 +1000
From:   Balbir Singh <bsingharora@...il.com>
To:     Jérôme Glisse <jglisse@...hat.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Dan Williams <dan.j.williams@...el.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        John Hubbard <jhubbard@...dia.com>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [HMM 06/15] mm/memory_hotplug: introduce add_pages

On Wed, 24 May 2017 13:20:15 -0400
Jérôme Glisse <jglisse@...hat.com> wrote:

> From: Michal Hocko <mhocko@...e.com>
> 
> There are new users of memory hotplug emerging. Some of them require
> different subset of arch_add_memory. There are some which only require
> allocation of struct pages without mapping those pages to the kernel
> address space. We currently have __add_pages for that purpose. But this
> is rather lowlevel and not very suitable for the code outside of the
> memory hotplug. E.g. x86_64 wants to update max_pfn which should be
> done by the caller. Introduce add_pages() which should care about those
> details if they are needed. Each architecture should define its
> implementation and select CONFIG_ARCH_HAS_ADD_PAGES. All others use
> the currently existing __add_pages.
> 
> Signed-off-by: Michal Hocko <mhocko@...e.com>
> Signed-off-by: Jérôme Glisse <jglisse@...hat.com>
> ---

Acked-by: Balbir Singh <bsingharora@...il.com>

Looks good, from a CDM perspective, this means that HMM-CDM would continue
to use arch_add_memory()

Balbir Singh.