lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 May 2017 18:57:53 -0700 From: Stephen Boyd <sboyd@...eaurora.org> To: Kiran Gunda <kgunda@...eaurora.org> Cc: Abhijeet Dharmapurikar <adharmap@...eaurora.org>, Subbaraman Narayanamurthy <subbaram@...eaurora.org>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, David Collins <collinsd@...eaurora.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, adharmap@...cinc.com, aghayal@....qualcomm.com Subject: Re: [PATCH V1 05/15] spmi: pmic-arb: cleanup unrequested irqs On 05/30, Kiran Gunda wrote: > From: Abhijeet Dharmapurikar <adharmap@...eaurora.org> > > We see a unmapped irqs trigger right around bootup. This could > likely be because the bootloader exited leaving the interrupts > in an unknown or unhandled state. Ack and mask the interrupt > if one is found. A request_irq later will unmask it and also > setup proper mapping structures. Do we have systems where this is causing an interrupt storm due to a level high interrupt or something? Just plain acking and masking irqs at boot if we don't have an irq descriptor created yet doesn't sound like a good idea, because we'll lose all interrupts that happen before this driver probes? > > Also the current driver ensures that no read/write transaction > is in progress while it makes changes to the interrupt regions. > This is not necessary because read/writes over spmi and arbiter > interrupt control are independent operations. Hence, remove the > synchronized accesses to interrupt region. That's another patch for this paragraph. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Powered by blists - more mailing lists