linux-kernel - Re: [PATCH] i2c: at91: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170531120542.iscumzwkhbkd2wuv@rfolt0960.corp.atmel.com>
Date:   Wed, 31 May 2017 14:05:42 +0200
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
CC:     <ludovic.desroches@...rochip.com>, <wsa@...-dreams.de>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: at91: Handle return value of clk_prepare_enable

On Wed, May 31, 2017 at 12:27:44PM +0530, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
I would split this patch in:
- add missing clk_disable_unprepare()
- check clk_prepare_enable() return value

Since there are trivial fixes, maybe having them squashed is ok.

Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

Thanks
> ---
>  drivers/i2c/busses/i2c-at91.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index fabbb9e..2525cd9 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -1083,12 +1083,16 @@ static int at91_twi_probe(struct platform_device *pdev)
>  		dev_err(dev->dev, "no clock defined\n");
>  		return -ENODEV;
>  	}
> -	clk_prepare_enable(dev->clk);
> +	rc = clk_prepare_enable(dev->clk);
> +	if (rc)
> +		return rc;
>  
>  	if (dev->dev->of_node) {
>  		rc = at91_twi_configure_dma(dev, phy_addr);
> -		if (rc == -EPROBE_DEFER)
> +		if (rc == -EPROBE_DEFER) {
> +			clk_disable_unprepare(dev->clk);
>  			return rc;
> +		}
>  	}
>  
>  	if (!of_property_read_u32(pdev->dev.of_node, "atmel,fifo-size",
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html