linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: remove false-positive bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <995a8c2b-d29f-5c82-6d7c-90e93770f620@kernel.org>
Date:   Wed, 31 May 2017 21:24:18 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove false-positive bug_on

Hi Jaegeuk,

On 2017/5/27 7:59, Jaegeuk Kim wrote:
> If we got failure from both of create and evict_inode, we can hit this wrong
> bug_on.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/inode.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index e53c784ab11e..5673b0bd83b5 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -426,8 +426,6 @@ void f2fs_evict_inode(struct inode *inode)
>  		alloc_nid_failed(sbi, inode->i_ino);
>  		clear_inode_flag(inode, FI_FREE_NID);
>  	}
> -	f2fs_bug_on(sbi, err &&
> -		!exist_written_data(sbi, inode->i_ino, ORPHAN_INO));

We expect that we can keep the inode in orphan list in
handle_failed_inode path when inode page have been persisted, so that if
there is anything error in evice_inode, we can have another chance to
release inode resource during next mount.

Here we need to check this case, additionally, if we failed to add the
inode into orphan list in handle_failed_inode, we must have set
SBI_NEED_FSCK in cp pack, so we need check the case too.

So we can change the code to:

f2fs_bug_on(err && err != -ENOENT &&
		(!exist_written_data(sbi, inode->i_ino, ORPHAN_INO) ||
		!is_sbi_flag_set(sbi, SBI_NEED_FSCK));

How do you think?

Thanks,

>  out_clear:
>  	fscrypt_put_encryption_info(inode, NULL);
>  	clear_inode(inode);
>