linux-kernel - Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53360973-098e-14fa-88e9-b0864822359a@nvidia.com>
Date:   Wed, 31 May 2017 15:23:49 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>,
        <p.zabel@...gutronix.de>, <linux-kernel@...r.kernel.org>
CC:     <linux-tegra@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <balbi@...nel.org>, <gregkh@...uxfoundation.org>,
        <linux-arm-msm@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage
 reset controllers


On 22/05/17 12:23, Vivek Gautam wrote:
> Make use of reset_control_array_*() set of APIs to manage
> an array of reset controllers available with the device.
> 
> Cc: Jon Hunter <jonathanh@...dia.com>
> Cc: Thierry Reding <treding@...dia.com>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> ---
>  drivers/soc/tegra/pmc.c | 91 +++++++++++++++++--------------------------------
>  1 file changed, 31 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index e233dd5dcab3..668f5d3d3635 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -124,8 +124,8 @@ struct tegra_powergate {
>  	unsigned int id;
>  	struct clk **clks;
>  	unsigned int num_clks;
> -	struct reset_control **resets;
> -	unsigned int num_resets;
> +	struct reset_control *reset;
> +	struct reset_control_array *resets;

It's a shame we can't avoid this additional reset pointer, but maybe
there is no good alternative for now. So ...

Acked-by: Jon Hunter <jonathanh@...dia.com>
Tested-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon

-- 
nvpublic