linux-kernel - Re: [PATCH] selftests: sync: Skip the test if kernel support is not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 May 2017 08:57:55 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Gustavo Padovan <gustavo.padovan@...labora.com>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     linux-kselftest@...r.kernel.org, emilio.lopez@...labora.co.uk,
        linux-kernel@...r.kernel.org, fathi.boudra@...aro.org,
        shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests: sync: Skip the test if kernel support is not
 found

On 05/31/2017 08:44 AM, Gustavo Padovan wrote:
> Hi Michael,
> 
> On 05/31/2017 07:40 PM, Michael Ellerman wrote:
>> The "Sync framework" test doesn't work if the kernel has no support,
>> obviously. Rather than reporting a failure, check for the kernel support
>> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
>> test.
>>
>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>> ---
>>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
>> index 9ea08d9f0b13..62fa666e501a 100644
>> --- a/tools/testing/selftests/sync/sync_test.c
>> +++ b/tools/testing/selftests/sync/sync_test.c
>> @@ -29,6 +29,7 @@
>>  #include <unistd.h>
>>  #include <stdlib.h>
>>  #include <sys/types.h>
>> +#include <sys/stat.h>
>>  #include <sys/wait.h>
>>  
>>  #include "synctest.h"
>> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>>  	exit(test());
>>  }
>>  
>> +static int sync_api_supported(void)
>> +{
>> +	struct stat sbuf;
>> +
>> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
>> +}
>> +
>>  int main(void)
>>  {
>>  	int err = 0;
>>  
>> +	if (!sync_api_supported()) {
>> +		printf("SKIP: Sync framework not supported by kernel\n");
>> +		return 0;
>> +	}
>> +
>>  	printf("[RUN]\tTesting sync framework\n");
>>  
>>  	err += RUN_TEST(test_alloc_timeline);
>>
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.com>
> 

Thanks both. I will pull this into kselftest for 4.13-rc1

-- Shuah