linux-kernel - Re: [PATCH net-next] net: dsa: remove dev arg of dsa_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170531.123601.869584973980453827.davem@davemloft.net>
Date:   Wed, 31 May 2017 12:36:01 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...oirfairelinux.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com, f.fainelli@...il.com, andrew@...n.ch
Subject: Re: [PATCH net-next] net: dsa: remove dev arg of
 dsa_register_switch

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Fri, 26 May 2017 18:12:51 -0400

> The current dsa_register_switch function takes a useless struct device
> pointer argument, which always equals ds->dev.
> 
> Drivers either call it with ds->dev, or with the same device pointer
> passed to dsa_switch_alloc, which ends up being assigned to ds->dev.
> 
> This patch removes the second argument of the dsa_register_switch and
> _dsa_register_switch functions.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Those invariants seem to hold indeed, so this looks fine, applied.