linux-kernel - Re: [PATCH] pstore: Fix leaked pstore_record in pstore_get_backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKnXaFrGxLpQAiEOZGtLm=gGdTDkHUKCQ9_XCFZFRJeiQ@mail.gmail.com>
Date:   Wed, 31 May 2017 09:54:28 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pstore: Fix leaked pstore_record in pstore_get_backend_records()

On Tue, May 30, 2017 at 3:50 PM, Douglas Anderson <dianders@...omium.org> wrote:
> When the "if (record->size <= 0)" test is true in
> pstore_get_backend_records() it's pretty clear that nobody holds a
> reference to the allocated pstore_record, yet we don't free it.
>
> Let's free it.
>
> Fixes: 2a2b0acf768c ("pstore: Allocate records on heap instead of stack")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Thanks! Applied for -next.

-Kees

> ---
>  fs/pstore/platform.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index d468eec9b8a6..9defe98ff8b1 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -846,8 +846,10 @@ void pstore_get_backend_records(struct pstore_info *psi,
>                 record->size = psi->read(record);
>
>                 /* No more records left in backend? */
> -               if (record->size <= 0)
> +               if (record->size <= 0) {
> +                       kfree(record);
>                         break;
> +               }
>
>                 decompress_record(record);
>                 rc = pstore_mkfile(root, record);
> --
> 2.13.0.219.gdb65acc882-goog
>



-- 
Kees Cook
Pixel Security