linux-kernel - Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170531165540.GA9371@amd>
Date:   Wed, 31 May 2017 18:55:40 +0200
From:   Pavel Machek <pavel@....cz>
To:     Wu Fenglin <fenglinw@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        'Richard Purdie' <rpurdie@...ys.net>,
        'Jacek Anaszewski' <jacek.anaszewski@...il.com>,
        'Rob Herring' <robh+dt@...nel.org>,
        'Mark Rutland' <mark.rutland@....com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        subbaram@...cinc.com, aghayal@....qualcomm.com, wruan@...cinc.com,
        kgunda@....qualcomm.com
Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI
 TRI_LED module

Hi!

> Thanks for the reviewing.
> 
> For the order, the hardware register mapping has this order (blue/green/red)
> from bit0/1/2, I can revert it to (red/green/blue) if there is a strong
> concern.

I'd do that.

> For these two properties: qcom,off-ms/ qcom,on-ms, I am using them to assign
> the default blinking on/off time, then the LEDs would have a default
> blinking pattern if you do "echo 1 > /sys/class/leds/red/blink"

Normally, dts describes hardware; this does not seem to be hardware
description, so I'd leave it out.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)