linux-kernel - Re: [PATCH v2] drm/pl111: fix warnings without CONFIG_ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d1ao3mqs.fsf@eliezer.anholt.net>
Date:   Wed, 31 May 2017 11:27:39 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/pl111: fix warnings without CONFIG_ARM_AMBA

Arnd Bergmann <arnd@...db.de> writes:

> The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA,
> but it just causes needless warnings:
>
> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable]
> drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function]
>
> This unhides the probe/remove functions again and just leaves the driver
> object as unused when CONFIG_ARM_AMBA is disabled, with a __maybe_unused
> annotation to shut up the warning.
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed and merged.  Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)