[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a0671efc-4c4e-bbdc-c9d8-a7bdc22b872a@suse.de>
Date: Fri, 2 Jun 2017 06:00:17 +1000
From: Aleksa Sarai <asarai@...e.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jslaby@...e.com>, Arnd Bergmann <arnd@...db.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
alpha <linux-alpha@...r.kernel.org>,
Linux MIPS Mailing List <linux-mips@...ux-mips.org>,
Parisc List <linux-parisc@...r.kernel.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
Linux-sh list <linux-sh@...r.kernel.org>,
sparclinux <sparclinux@...r.kernel.org>,
"linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
Linux-Arch <linux-arch@...r.kernel.org>,
Christian Brauner <christian.brauner@...ntu.com>,
Valentin Rothberg <vrothberg@...e.com>
Subject: Re: [PATCH] tty: add TIOCGPTPEER ioctl
>> --- a/arch/alpha/include/uapi/asm/ioctls.h
>> +++ b/arch/alpha/include/uapi/asm/ioctls.h
>> @@ -94,6 +94,7 @@
>> #define TIOCSRS485 _IOWR('T', 0x2F, struct serial_rs485)
>> #define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of pty-mux device) */
>> #define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */
>> +#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */
>
> Shouldn't the list of definitions be kept sorted, by hex number?
> (everywhere)
Probably. The reason I put it here is because it logically is very
similar to TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is
more important for maintainence.
--
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
Powered by blists - more mailing lists