linux-kernel - Re: [PATCH] perf sort: only insert overhead && overhead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170601102139.GA13811@krava>
Date:   Thu, 1 Jun 2017 12:21:39 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     changbin.du@...el.com
Cc:     peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf sort: only insert overhead && overhead_children
 when no overhead* field given

On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@...el.com wrote:
> From: Changbin Du <changbin.du@...el.com>
> 
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first.Ths will be a problem if the data is collected with call-graph
> enabled. Then we never can sort the result as self-overhead on this
> data. And sometimes the data is hard to collect.
> 
> This patch fix this by only insert overhead && overhead_children
> when no overhead* field given.
> 
> Signed-off-by: Changbin Du <changbin.du@...el.com>
> ---
>  tools/perf/util/sort.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 5762ae4..69eea3a 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
>  	if (sort__mode == SORT_MODE__DIFF)
>  		return keys;
>  
> +	if (strstr(keys, "overhead"))
> +		return keys;
> +
>  	keys = prefix_if_not_in("overhead", keys);

hum, you basicaly do what's at begining of prefix_if_not_in function:

static char *prefix_if_not_in(const char *pre, char *str)
{
        char *n;

        if (!str || strstr(str, pre))
                return str;
        ...


could you please provide the example described in changelog?

jirka