lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Jun 2017 15:28:18 +0300 From: Rakesh Pandit <rakesh@...era.com> To: Christoph Hellwig <hch@....de> CC: Sagi Grimberg <sagi@...mberg.me>, <linux-nvme@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...com>, Keith Busch <keith.busch@...el.com>, Andy Lutomirski <luto@...nel.org> Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever On Thu, Jun 01, 2017 at 01:43:38PM +0200, Christoph Hellwig wrote: > On Tue, May 30, 2017 at 05:23:46PM +0300, Rakesh Pandit wrote: > > We can fix user-space triggered set_features higger up e.g. in > > nvme_ioctl by putting same check. Introduction of a separate state > > NVME_CTRL_SCHED_RESET (being discussed in another thread) has > > additional advantage of making sure that only one thread is going > > through resetting and eventually through removal (if required) and > > solves lot of problems. > > I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty > sure some time in the past I already had it in a local tree as a > generalization of rdma and loop already use NVME_CTRL_RESETTING > (they set it before queueing the reset work). > > But I don't fully understand how the NVME_CTRL_SCHED_RESET fix is > related to this patch? They aren't related. Sorry for confusion. I intended to answer another thread but instead wrote it here.
Powered by blists - more mailing lists