linux-kernel - Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170601131232.GA12630@amd>
Date:   Thu, 1 Jun 2017 15:12:32 +0200
From:   Pavel Machek <pavel@....cz>
To:     Darwin Dingel <Darwin.Dingel@...iedtelesis.co.nz>
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        "richard@....at" <richard@....at>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "cyrille.pitchen@...el.com" <cyrille.pitchen@...el.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mark.marshall@...cronenergy.com" <mark.marshall@...cronenergy.com>,
        "b44839@...escale.com" <b44839@...escale.com>,
        "prabhakar@...escale.com" <prabhakar@...escale.com>
Subject: Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased
 pages

On Thu 2017-06-01 01:09:17, Darwin Dingel wrote:
> Hi Pavel,
> 
> Just a minor thing. Sorry about the late comment.
> 
> On 01/06/17 08:59, Pavel Machek wrote:
> > +
> > +		res = check_erased_page(chip, buf);
> > +		return res;
> > +	}
> 
> Can we just remove 'res' and change this line to:
> 	return check_erased_page(chip, buf);

Well... I originally had a printk there, and yes, it can be
simplified. I can roll v3, if required, but I'd leave it as is -- it
is still convenient place to add debugging to.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)