linux-kernel - Re: [PATCH 7/7] HID: remove no longer used hid->open field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201706011020.JEssZgIa%fengguang.wu@intel.com>
Date:   Thu, 1 Jun 2017 11:08:04 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     kbuild-all@...org, Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] HID: remove no longer used hid->open field

Hi Dmitry,

[auto build test ERROR on hid/for-next]
[also build test ERROR on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/HID-Consolidate-serializing-ope-close-in-transport-drivers/20170601-092350
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging//greybus/hid.c: In function 'gb_hid_open':
>> drivers/staging//greybus/hid.c:352:10: error: 'struct hid_device' has no member named 'open'
     if (!hid->open++) {
             ^~
   drivers/staging//greybus/hid.c:355:7: error: 'struct hid_device' has no member named 'open'
       hid->open--;
          ^~
   drivers/staging//greybus/hid.c: In function 'gb_hid_close':
   drivers/staging//greybus/hid.c:374:12: error: 'struct hid_device' has no member named 'open'
     if (!--hid->open) {
               ^~

vim +352 drivers/staging//greybus/hid.c

96eab779 Viresh Kumar 2015-03-16  346  static int gb_hid_open(struct hid_device *hid)
96eab779 Viresh Kumar 2015-03-16  347  {
96eab779 Viresh Kumar 2015-03-16  348  	struct gb_hid *ghid = hid->driver_data;
96eab779 Viresh Kumar 2015-03-16  349  	int ret = 0;
96eab779 Viresh Kumar 2015-03-16  350  
96eab779 Viresh Kumar 2015-03-16  351  	mutex_lock(&gb_hid_open_mutex);
96eab779 Viresh Kumar 2015-03-16 @352  	if (!hid->open++) {
96eab779 Viresh Kumar 2015-03-16  353  		ret = gb_hid_set_power(ghid, GB_HID_TYPE_PWR_ON);
96eab779 Viresh Kumar 2015-03-16  354  		if (ret < 0)
96eab779 Viresh Kumar 2015-03-16  355  			hid->open--;

:::::: The code at line 352 was first introduced by commit
:::::: 96eab779e1985fd0b39426d288d3af38e3bce50c greybus: hid: add HID class driver

:::::: TO: Viresh Kumar <viresh.kumar@...aro.org>
:::::: CC: Greg Kroah-Hartman <greg@...ah.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (59136 bytes)