linux-kernel - Re: [PATCH] mISDN: Fix a sleep-in-atomic bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170601.145013.397328786892049824.davem@davemloft.net>
Date:   Thu, 01 Jun 2017 14:50:13 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@....com
Cc:     isdn@...ux-pingi.de, mingo@...nel.org, fweisbec@...il.com,
        geliangtang@...il.com, akpm@...ux-foundation.org,
        yamada.masahiro@...ionext.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mISDN: Fix a sleep-in-atomic bug

From: Jia-Ju Bai <baijiaju1990@....com>
Date: Wed, 31 May 2017 15:08:25 +0800

> The driver may sleep under a read spin lock, and the function call path is:
> send_socklist (acquire the lock by read_lock)
>   skb_copy(GFP_KERNEL) --> may sleep
> 
> To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@....com>

Just proves that nobody has ever run this code with lock debugging
enabled, if at all.

Applied, thanks.