linux-kernel - Re: [PATCH] HID: asus: Stop underlying hardware on remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170602073100.GL1293@mail.corp.redhat.com>
Date:   Fri, 2 Jun 2017 09:31:00 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Carlo Caione <carlo@...one.org>
Cc:     jikos@...nel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...lessm.com,
        Carlo Caione <carlo@...lessm.com>
Subject: Re: [PATCH] HID: asus: Stop underlying hardware on remove

On May 30 2017 or thereabouts, Carlo Caione wrote:
> From: Carlo Caione <carlo@...lessm.com>
> 
> We are missing a call to hid_hw_stop() on the remove hook.
> Among other things this is causing an Oops when (re-)starting GNOME /
> upowerd / ... after the module has been already rmmod-ed.

Good catch:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

> 
> Signed-off-by: Carlo Caione <carlo@...lessm.com>
> ---
>  drivers/hid/hid-asus.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 16df6cc..2e9642d 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev)
>  		drvdata->kbd_backlight->removed = true;
>  		cancel_work_sync(&drvdata->kbd_backlight->work);
>  	}
> +
> +	hid_hw_stop(hdev);
>  }
>  
>  static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> -- 
> 2.9.3
>