linux-kernel - Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877f0uvgqk.fsf@linux.intel.com>
Date:   Fri, 02 Jun 2017 13:14:27 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Chunyan Zhang <zhang.chunyan@...aro.org>
Subject: Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()


Hi,

kbuild test robot <lkp@...el.com> writes:
> Hi Felipe,
>
> [auto build test ERROR on tip/perf/core]
> [also build test ERROR on v4.12-rc1 next-20170518]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Felipe-Balbi/kernel-trace-pass-export-pointer-as-argument-to-write/20170518-135452
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> All errors (new ones prefixed by >>):
>
>    drivers/hwtracing/stm/ftrace.c: In function 'stm_ftrace_write':
>>> drivers/hwtracing/stm/ftrace.c:49:19: error: incompatible type for argument 1 of 'stm_source_write'
>      stm_source_write(stm->data, STM_FTRACE_CHAN, buf, len);
>                       ^~~
>    In file included from drivers/hwtracing/stm/ftrace.c:18:0:
>    include/linux/stm.h:136:13: note: expected 'struct stm_source_data *' but argument is of type 'struct stm_source_data'
>     int notrace stm_source_write(struct stm_source_data *data, unsigned int chan,
>                 ^~~~~~~~~~~~~~~~
>
> vim +/stm_source_write +49 drivers/hwtracing/stm/ftrace.c
>
>     43	 */
>     44	static void notrace
>     45	stm_ftrace_write(struct trace_export *export, const void *buf, unsigned int len)
>     46	{
>     47		struct stm_ftrace *stm = container_of(export, struct stm_ftrace, ftrace);
>     48	
>   > 49		stm_source_write(stm->data, STM_FTRACE_CHAN, buf, len);

sorry, just came back from vacations and noticed this. I'll send a v2 shortly.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)