linux-kernel - Re: [PATCH 4.4 075/103] [media] dvb-frontends/cxd2841er: define symbol_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496403267.1989.5.camel@codethink.co.uk>
Date:   Fri, 02 Jun 2017 12:34:27 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Daniel Scheller <d.scheller@....net>,
        Abylay Ospan <aospan@...up.ru>,
        Mauro Carvalho Chehab <mchehab@...pensource.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.4 075/103] [media] dvb-frontends/cxd2841er: define
 symbol_rate_min/max in T/C fe-ops

On Tue, 2017-05-23 at 22:09 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Daniel Scheller <d.scheller@....net>
> 
> commit 158f0328af86a99d64073851967a02694bff987d upstream.
> 
> Fixes "w_scan -f c" complaining with
> 
>   This dvb driver is *buggy*: the symbol rate limits are undefined - please
>   report to linuxtv.org)
> 
> Signed-off-by: Daniel Scheller <d.scheller@....net>
> Acked-by: Abylay Ospan <aospan@...up.ru>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@...pensource.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

In 4.4 this driver had two separate ops structures for DVB-T and DVB-C,
and this is only updating the DVB-C ops.  I think this needs a second
patch to cover DVB-T.

Ben.

> ---
>  drivers/media/dvb-frontends/cxd2841er.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> --- a/drivers/media/dvb-frontends/cxd2841er.c
> +++ b/drivers/media/dvb-frontends/cxd2841er.c
> @@ -2678,7 +2678,9 @@ static struct  dvb_frontend_ops cxd2841e
>  			FE_CAN_MUTE_TS |
>  			FE_CAN_2G_MODULATION,
>  		.frequency_min = 42000000,
> -		.frequency_max = 1002000000
> +		.frequency_max = 1002000000,
> +		.symbol_rate_min = 870000,
> +		.symbol_rate_max = 11700000
>  	},
>  	.init = cxd2841er_init_tc,
>  	.sleep = cxd2841er_sleep_tc,
> 
> 
> 

-- 
Ben Hutchings
Software Developer, Codethink Ltd.