linux-kernel - Re: hexagon: Use raw_copy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Jun 2017 06:03:53 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Richard Kuo <rkuo@...eaurora.org>
Cc:     linux-hexagon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: hexagon: Use raw_copy_to_user

ping ....

On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> all callers, resulting in the following build error.
> 
> arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> arch/hexagon/mm/uaccess.c:40:3: error:
> 	implicit declaration of function '__copy_to_user_hexagon'
> 
> Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> Acked-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  arch/hexagon/mm/uaccess.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> index ec90afdb3ad0..c599eb126c9e 100644
> --- a/arch/hexagon/mm/uaccess.c
> +++ b/arch/hexagon/mm/uaccess.c
> @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
>  	long uncleared;
>  
>  	while (count > PAGE_SIZE) {
> -		uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> -						PAGE_SIZE);
> +		uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
>  		if (uncleared)
>  			return count - (PAGE_SIZE - uncleared);
>  		count -= PAGE_SIZE;
>  		dest += PAGE_SIZE;
>  	}
>  	if (count)
> -		count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> +		count = raw_copy_to_user(dest, &empty_zero_page, count);
>  
>  	return count;
>  }