linux-kernel - Re: [PATCH] net: phy: marvell: make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170602140014.GK12261@lunn.ch>
Date:   Fri, 2 Jun 2017 16:00:14 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Colin King <colin.king@...onical.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: phy: marvell: make two functions static

On Fri, Jun 02, 2017 at 12:14:24PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> functions m88e1510_get_temp_critical and m88e1510_get_temp_alarm can be
> made static as they not need to be in global scope.
> 
> Cleans up sparse warnings:
>  "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
>  "symbol 'm88e1510_get_temp_critical' was not declared. Should it be 
>   static?"

Hi Colin

What about m88e1510_get_temp_alarm()? That should also have a static.

Thanks
     Andrew