linux-kernel - Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170602140433.GM2899@kernel.org>
Date:   Fri, 2 Jun 2017 11:04:33 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc

Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu:
>  
> +		if (t->is_supported && !t->is_supported()) {
> +			pr_debug("%2d: %-*s: Disabled\n", i, width, t->desc);

This isn't clear, I'll change this to leave the pr_debug up to the
->is_supported() code (that will receive the struct test pointer too),
that can then say something more clear like what you put in that
comment.

This way, ppc hackers running 'perf test' will see that longstanding
TODO entry ;-)

- Arnaldo

> +			continue;
> +		}
> +
>  		pr_info("%2d: %-*s:", i, width, t->desc);
>  
>  		if (intlist__find(skiplist, i)) {
> diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
> index 631859629403..577363809c9b 100644
> --- a/tools/perf/tests/tests.h
> +++ b/tools/perf/tests/tests.h
> @@ -34,6 +34,7 @@ struct test {
>  		int (*get_nr)(void);
>  		const char *(*get_desc)(int subtest);
>  	} subtest;
> +	bool (*is_supported)(void);
>  };
>  
>  /* Tests */
> @@ -99,6 +100,8 @@ const char *test__clang_subtest_get_desc(int subtest);
>  int test__clang_subtest_get_nr(void);
>  int test__unit_number__scnprint(int subtest);
>  
> +bool test__bp_signal_is_supported(void);
> +
>  #if defined(__arm__) || defined(__aarch64__)
>  #ifdef HAVE_DWARF_UNWIND_SUPPORT
>  struct thread;
> -- 
> 2.9.4