linux-kernel - Re: [PATCHv6 06/10] x86/mm: Add sync_global_pgds() for configuration with 5-level paging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170602150451.nspo54dzp7y54wdk@node.shutemov.name>
Date:   Fri, 2 Jun 2017 18:04:51 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Andy Lutomirski <luto@...capital.net>,
        Dan Williams <dan.j.williams@...el.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv6 06/10] x86/mm: Add sync_global_pgds() for configuration
 with 5-level paging

On Fri, Jun 02, 2017 at 05:50:34PM +0300, Andrey Ryabinin wrote:
> On 05/24/2017 12:54 PM, Kirill A. Shutemov wrote:
> > This basically restores slightly modified version of original
> > sync_global_pgds() which we had before folded p4d was introduced.
> > 
> > The only modification is protection against 'addr' overflow.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > ---
> >  arch/x86/mm/init_64.c | 39 +++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 39 insertions(+)
> > 
> > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > index 95651dc58e09..ce410c05d68d 100644
> > --- a/arch/x86/mm/init_64.c
> > +++ b/arch/x86/mm/init_64.c
> > @@ -92,6 +92,44 @@ __setup("noexec32=", nonx32_setup);
> >   * When memory was added make sure all the processes MM have
> >   * suitable PGD entries in the local PGD level page.
> >   */
> > +#ifdef CONFIG_X86_5LEVEL
> > +void sync_global_pgds(unsigned long start, unsigned long end)
> > +{
> > +	unsigned long addr;
> > +
> > +	for (addr = start; addr <= end; addr += ALIGN(addr + 1, PGDIR_SIZE)) {
> 
>                                         addr = ALIGN(addr + 1, PGDIR_SIZE)

Ouch. Thanks for noticing this.

Strange that it haven't crashed anywhere in my tests.

-- 
 Kirill A. Shutemov