linux-kernel - [PATCH 5/6] arm64: move COMPAT_ELF_ET_DYN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170602152010.2064-6-riel@redhat.com>
Date:   Fri,  2 Jun 2017 11:20:09 -0400
From:   riel@...hat.com
To:     linux-kernel@...r.kernel.org
Cc:     kernel-hardening@...ts.openwall.com, akpm@...ux-foundation.org,
        mingo@...nel.org, oleg@...hat.com, lwoodman@...hat.com,
        mhocko@...e.de, danielmicay@...il.com, will.deacon@....com,
        benh@...nel.crashing.org
Subject: [PATCH 5/6] arm64: move COMPAT_ELF_ET_DYN_BASE lower in the address space

From: Rik van Riel <riel@...hat.com>

When setting up mmap_base, we take care to start the mmap base
below the maximum extent to which the stack will grow. However,
we take no such precautions with PIE binaries, which are placed
at 2/3 of TASK_SIZE plus a random offset. As a result, 32 bit PIE
binaries can end up smack in the middle of where the stack (which
is randomized down) is supposed to go.

That problem can be avoided by putting the 32 bit ELF_ET_DYN_BASE
at 256MB, which is a value linux-hardened and grsecurity have used
for a long time now without any known (to me) bug reports.

Signed-off-by: Rik van Riel <riel@...hat.com>
Signed-off-by: Daniel Micay <danielmicay@...il.com>
---
 arch/arm64/include/asm/elf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h
index 5d1700425efe..88808a761816 100644
--- a/arch/arm64/include/asm/elf.h
+++ b/arch/arm64/include/asm/elf.h
@@ -173,7 +173,7 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm,

 #ifdef CONFIG_COMPAT

-#define COMPAT_ELF_ET_DYN_BASE		(2 * TASK_SIZE_32 / 3)
+#define COMPAT_ELF_ET_DYN_BASE		(0x10000000UL)

 /* AArch32 registers. */
 #define COMPAT_ELF_NGREG		18
-- 
2.9.3