linux-kernel - Re: [PATCH][V2] net: phy: marvell: make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5268b842-3784-36f7-7c6f-e1b4b670f8b5@gmail.com>
Date:   Fri, 2 Jun 2017 09:48:29 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] net: phy: marvell: make some functions static



On 06/02/2017 07:13 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and
> m88e1510_get_temp_alarm can be made static as they not need to be
> in global scope.
> 
> Cleans up sparse warnings:
>  "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
>  "symbol 'm88e1510_get_temp_critical' was not declared. Should it be
>   static?"
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian