[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOw6vbKtC3wsPvUBsyebd3L2v0rAgH_Tj_tbdr0d+-+a1XBAWw@mail.gmail.com>
Date: Fri, 2 Jun 2017 14:52:47 -0400
From: Sean Paul <seanpaul@...omium.org>
To: John Stultz <john.stultz@...aro.org>
Cc: Xinliang Liu <xinliang.liu@...aro.org>,
lkml <linux-kernel@...r.kernel.org>,
Rob Herring <robh@...nel.org>,
Archit Taneja <architt@...eaurora.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Maxime Ripard <maxime.ripard@...e-electrons.com>,
Dave Airlie <airlied@...il.com>
Subject: Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion
On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <john.stultz@...aro.org> wrote:
> On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <xinliang.liu@...aro.org> wrote:
>> On 24 May 2017 at 00:40, John Stultz <john.stultz@...aro.org> wrote:
>>>
>>> This fixes a regression introduced by ebc944613567 ("drm:
>>> convert drivers to use drm_of_find_panel_or_bridge") that was
>>> recently merged, causing HDMI output to not work.
>>>
>>> For the kirin driver, the port value should be 1 instead of 0,
>>> so this oneline patch fixes it and gets graphics working again.
>>>
>>> Cc: Rob Herring <robh@...nel.org>
>>> Cc: Archit Taneja <architt@...eaurora.org>
>>> Cc: Philipp Zabel <p.zabel@...gutronix.de>
>>> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
>>> Cc: Sean Paul <seanpaul@...omium.org>
>>> Cc: Dave Airlie <airlied@...il.com>
>>> Cc:
>>> Xinliang Liu <xinliang.liu@...aro.org>
>>> Fix-suggested-by: Rob Herring <robh@...nel.org>
>>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>>
>>
>> Looks good to me. Thanks for the patch.
>>
>> Reviewed-by:
>> Xinliang Liu <xinliang.liu@...aro.org>
>>
>
> Just wanted to check in on this. Is there someone I'm missing from the
> cc list on this?
>
Hi John,
Apologies, I just saw this. Slipped through my cracks because it's not
posted on dri-devel.
The patch looks good. I'll pick it up in drm-misc-fixes if Dave
doesn't take it directly into drm-fixes.
Sean
> thanks
> -john
Powered by blists - more mailing lists