linux-kernel - Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5611a2c-7348-7059-8b26-de0d7cd77ccb@kernel.org>
Date:   Fri, 2 Jun 2017 13:31:50 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Mickaël Salaün <mic@...ikod.net>,
        linux-kernel@...r.kernel.org
Cc:     Andy Lutomirski <luto@...capital.net>,
        Jonathan Corbet <corbet@....net>,
        Kees Cook <keescook@...omium.org>,
        Will Drewry <wad@...omium.org>, linux-doc@...r.kernel.org,
        linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to
 dependencies

Hi Mickaël,

On 05/26/2017 12:43 PM, Mickaël Salaün wrote:
> Rebuild the seccomp tests when kselftest_harness.h is updated.
> 
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> Acked-by: Kees Cook <keescook@...omium.org>
> Cc: Andy Lutomirski <luto@...capital.net>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Will Drewry <wad@...omium.org>
> ---
>  tools/testing/selftests/seccomp/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> index 5fa6fd2246b1..aeb0c805f3ca 100644
> --- a/tools/testing/selftests/seccomp/Makefile
> +++ b/tools/testing/selftests/seccomp/Makefile
> @@ -4,3 +4,5 @@ LDFLAGS += -lpthread
>  
>  include ../lib.mk
>  
> +$(TEST_GEN_PROGS): seccomp_bpf.c ../kselftest_harness.h
> +	$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
> 

This change breaks seccomp build:

make -C tools/testing/selftests/seccomp/
make: Entering directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp'
make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'.  Stop.
make: Leaving directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp'
shuah@...urka:/mnt/data/lkml/linux_4.12$ cd tools/testing/selftests/seccomp/
shuah@...urka:/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp$ make
make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'.  Stop.

Did you happen to try building with this change?

thanks,
-- Shuah