linux-kernel - Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPw-ZTkxjVWeo-bkHfYE5nABFdUZKqEZQLmoWxvVBU4pnhWL6g@mail.gmail.com>
Date:   Fri, 2 Jun 2017 13:37:40 -0700
From:   Loc Ho <lho@....com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Hoan Tran <hotran@....com>, linux-i2c@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Keyur Chudgar <kchudgar@....com>
Subject: Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

Hi Wolfram,

>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@....com>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> +       if (!acpi_disabled) {
> +               mbox_chan_txdone(ctx->mbox_chan, 0);
> +       }
>
> Fixed that and applied to for-next, thanks!
>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.

Thanks for fixing the warning message. Given that Duc has left MACOM
(previously APM), we are ramping up another person.

Thanks,
Loc