linux-kernel - Re: [PATCH] iio: humidity: hdc100x: document compatible HDC10xx devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170603092523.77b3b0ee@kernel.org>
Date:   Sat, 3 Jun 2017 09:25:23 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Michael Stecklein <m-stecklein@...com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Andrew F . Davis" <afd@...com>,
        Matt Ranostay <matt.ranostay@...sulko.com>
Subject: Re: [PATCH] iio: humidity: hdc100x: document compatible HDC10xx
 devices

On Fri, 2 Jun 2017 10:09:21 -0500
Michael Stecklein <m-stecklein@...com> wrote:

> Include datasheet links to compatible HDC10xx devices.
> 
> Signed-off-by: Michael Stecklein <m-stecklein@...com>
Hi Michael,

Would you mind also adding the i2c_device_id entries for these
other parts and updating the kconfig help to mention that they
are supported?  Hmm. Matt, the driver should really have listed
all the parts explicitly in the first place. I was clearly
half asleep whilst reviewing this one.

We'll need to leave the hdc100x entry in there for backwards
compatibility but please add all the others.

Might also be worth taking this opportunity to do an additional
patch adding devicetree bindings for this driver.

If you don't have time for any or all of the above, feel free
to say so!

Thanks,

Jonathan
> ---
> 
> Tested on the HDC1080 but not the HDC1010 and HDC1050, however
> their datasheets describe identical functionality.
> 
>  drivers/iio/humidity/hdc100x.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index aa17115..ef17613 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -13,6 +13,12 @@
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>   * GNU General Public License for more details.
>   *
> + * Datasheets:
> + * http://www.ti.com/product/HDC1000/datasheet
> + * http://www.ti.com/product/HDC1008/datasheet
> + * http://www.ti.com/product/HDC1010/datasheet
> + * http://www.ti.com/product/HDC1050/datasheet
> + * http://www.ti.com/product/HDC1080/datasheet
>   */
>  
>  #include <linux/delay.h>