linux-kernel - Re: [PATCH v3 09/27] thunderbolt: Convert switch to a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170603091132.GA1103@kroah.com>
Date:   Sat, 3 Jun 2017 18:11:32 +0900
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        Lukas Wunner <lukas@...ner.de>,
        Amir Levy <amir.jer.levy@...el.com>,
        Andy Lutomirski <luto@...nel.org>, Mario.Limonciello@...l.com,
        Jared.Dominguez@...l.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 09/27] thunderbolt: Convert switch to a device

On Fri, Jun 02, 2017 at 05:05:06PM +0300, Mika Westerberg wrote:
> Thunderbolt domain consists of switches that are connected to each
> other, forming a bus. This will convert each switch into a real Linux
> device structure and adds them to the domain. The advantage here is
> that we get all the goodies from the driver core, like reference
> counting and sysfs hierarchy for free.
> 
> Also expose device identification information to the userspace via new
> sysfs attributes.
> 
> In order to support internal connection manager (ICM) we separate switch
> configuration into its own function (tb_switch_configure()) which is
> only called by the existing native connection manager implementation
> used on Macs.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Reviewed-by: Yehezkel Bernat <yehezkel.bernat@...el.com>
> Reviewed-by: Michael Jamet <michael.jamet@...el.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-thunderbolt |  22 ++
>  drivers/thunderbolt/eeprom.c                    |   2 +
>  drivers/thunderbolt/switch.c                    | 261 +++++++++++++++++++-----
>  drivers/thunderbolt/tb.c                        |  40 +++-
>  drivers/thunderbolt/tb.h                        |  45 +++-
>  5 files changed, 303 insertions(+), 67 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-thunderbolt

For the driver model type changes, looks good to me, nice job:

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>