linux-kernel - Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjtHdHa2-HEJE+Tkft71ZotLiqEwdVJSu07ZV-8YnGeUQ@mail.gmail.com>
Date:   Sat, 3 Jun 2017 10:41:06 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com,
        David Ahern <dsahern@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data

Hi Jiri,

On Thu, Jun 1, 2017 at 8:29 PM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Thu, Jun 01, 2017 at 06:06:04PM +0900, Namhyung Kim wrote:
>
> SNIP
>
>> @@ -399,6 +438,7 @@ static int __open_dso(struct dso *dso, struct machine *machine)
>>       int fd;
>>       char *root_dir = (char *)"";
>>       char *name = malloc(PATH_MAX);
>> +     bool needs_unlink = false;
>>
>>       if (!name)
>>               return -ENOMEM;
>> @@ -415,7 +455,23 @@ static int __open_dso(struct dso *dso, struct machine *machine)
>>       if (!is_regular_file(name))
>>               return -EINVAL;
>>
>> +     if (dso__needs_decompress(dso)) {
>> +             char buf[32];
>> +
>> +             fd = dso__decompress_kmodule(dso, name, buf, sizeof(buf));
>> +             if (fd < 0)
>
>                         free(name)

ok.

>
>> +                     return -1;
>> +
>> +             close(fd);
>> +             strcpy(name, buf);
>
> also why not use name directly instead of buf?

The name should have original compressed filename and buf will be set
to a new decompressed name.

Thanks,
Namhyung