lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Jun 2017 23:40:39 +0200 From: Andrea Adami <andrea.adami@...il.com> To: Lee Jones <lee.jones@...aro.org> Cc: linux-mtd@...ts.infradead.org, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Boris Brezillon <boris.brezillon@...e-electrons.com>, Marek Vasut <marek.vasut@...il.com>, Richard Weinberger <richard@....at>, Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>, Wolfram Sang <wsa+renesas@...g-engineering.com>, Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>, Dmitry Eremin-Solenikov <dbaryshkov@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, Linus Walleij <linus.walleij@...aro.org>, Russell King <linux@...linux.org.uk>, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v3 3/9] mfd: tmio.h: support partition parser types On Thu, Jun 1, 2017 at 4:35 PM, Lee Jones <lee.jones@...aro.org> wrote: > On Thu, 01 Jun 2017, Andrea Adami wrote: > >> Signed-off-by: Andrea Adami <andrea.adami@...il.com> >> --- >> include/linux/mfd/tmio.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h >> index a1520d8..23bb069 100644 >> --- a/include/linux/mfd/tmio.h >> +++ b/include/linux/mfd/tmio.h >> @@ -139,6 +139,7 @@ struct tmio_nand_data { >> struct nand_bbt_descr *badblock_pattern; >> struct mtd_partition *partition; >> unsigned int num_partitions; >> + const char *const *types; /* names of parsers to use if any */ > > Please use kerneldoc instead. > Thanks for the review. tmio.h is not consistent and uses inline comments so I did not change the style. Another round of patches will be necessary to sanitize the comments, out of the scope of this little patchset. Cheers Andrea >> }; >> >> #define FBIO_TMIO_ACC_WRITE 0x7C639300 > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists