linux-kernel - Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-d5d6bc5a-5253-4b7c-8557-d3fd13f241a8@palmer-si-x1c4>
Date:   Fri, 02 Jun 2017 20:32:28 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     pavel@....cz
CC:     albert@...ive.com
Subject:     Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

On Thu, 25 May 2017 10:05:05 PDT (-0700), pavel@....cz wrote:
>> +static void ci_leaf_init(struct cacheinfo *this_leaf,
>> +                         struct device_node *node,
>> +                         enum cache_type type, unsigned int level)
>> +{
>> +        this_leaf->of_node = node;
>> +        this_leaf->level = level;
>> +        this_leaf->type = type;
>> +        this_leaf->physical_line_partition = 1; // not a sector cache
>> +        this_leaf->attributes = CACHE_WRITE_BACK | CACHE_READ_ALLOCATE | CACHE_WRITE_ALLOCATE; // TODO: add to DTS
>> +}
>
> You may want to run the patches through checkpatch. (Comment style,
> long lines).

Thanks.  Someone else suggested this and I've fixed most of the errors.  I'll
submit a v2 with everyone's feedback once I get through my mail.