lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 4 Jun 2017 18:06:02 +0300 From: Sagi Grimberg <sagi@...mberg.me> To: Johannes Thumshirn <jthumshirn@...e.de>, Christoph Hellwig <hch@....de>, Keith Busch <keith.busch@...el.com> Cc: Hannes Reinecke <hare@...e.de>, maxg@...lanox.com, Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>, Linux Kernel Mailinglist <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 5/8] nvme: get list of namespace descriptors On 04/06/17 13:36, Johannes Thumshirn wrote: > If a target identifies itself as NVMe 1.3 compliant, try to get the > list of Namespace Identification Descriptors and populate the UUID, > NGUID and EUI64 fileds in the NVMe namespace structure with these > values. > > Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de> > --- > drivers/nvme/host/core.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++ > drivers/nvme/host/nvme.h | 1 + > 2 files changed, 88 insertions(+) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 7b254be16887..37047841da0e 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -643,6 +643,85 @@ int nvme_identify_ctrl(struct nvme_ctrl *dev, struct nvme_id_ctrl **id) > return error; > } > > +static void nvme_parse_ns_descs(struct nvme_ns *ns, void *data) > +{ > + int pos; > + int len; > + > + for (pos = 0; pos < NVME_IDENTIFY_DATA_SIZE; pos += len) { > + struct nvme_ns_identifier_hdr *cur = data + pos; > + > + if (cur->nidl == 0) > + break; > + > + switch (cur->nidt) { > + case NVME_NIDT_EUI64: > + if (cur->nidl != NVME_NIDT_EUI64_LEN) { > + dev_warn(ns->ctrl->dev, > + "Target returned bogus length: %d for NVME_NIDT_EUI64\n", > + cur->nidl); Hmm, "target" is not a spec'd entity in NVMe AFAIR, and we try to avoid using this language in the host too, lets call it "ctrl".
Powered by blists - more mailing lists