linux-kernel - Re: [PATCH v3 06/27] thunderbolt: Rework capability handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170604150659.GH3454@lahna.fi.intel.com>
Date:   Sun, 4 Jun 2017 18:06:59 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        Amir Levy <amir.jer.levy@...el.com>,
        Andy Lutomirski <luto@...nel.org>, Mario.Limonciello@...l.com,
        Jared.Dominguez@...l.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 06/27] thunderbolt: Rework capability handling

On Sun, Jun 04, 2017 at 06:00:02PM +0300, Mika Westerberg wrote:
> On Sun, Jun 04, 2017 at 03:52:29PM +0200, Lukas Wunner wrote:
> > On Fri, Jun 02, 2017 at 05:05:03PM +0300, Mika Westerberg wrote:
> > > Organization of the capabilities in switches and ports is not so random
> > > after all. Rework the capability handling functionality so that it
> > > follows how capabilities are organized and provide two new functions
> > > (tb_switch_find_vsec_cap() and tb_port_find_cap()) which can be used to
> >                   ^^^^^^^^
> > 
> > I assume VSEC is the same acronym as in the PCIe spec, so this naming
> > scheme results in "vendor specific extended capability capability",
> > which is maybe a bit odd.
> 
> AFAIK it comes from Vendor SpEcifiC but I'm not 100% sure ;-) The Alpine
> Ridge datasheet calls it also VSEC capability which is why we chose the
> naming accordingly.

That said, it could also come from Vendor SpEcific Capability. I can
change it to tb_switch_find_vsec() if that works better.