lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 4 Jun 2017 12:38:50 -0700
From:   Yu Zhao <>
To:     Michal Hocko <>
Cc:     Johannes Weiner <>,
        Vladimir Davydov <>,,,
Subject: Re: [PATCH] swap: cond_resched in swap_cgroup_prepare()

On Fri, Jun 02, 2017 at 10:18:57AM +0200, Michal Hocko wrote:
> On Thu 01-06-17 12:56:35, Yu Zhao wrote:
> > Saw need_resched() warnings when swapping on large swapfile (TBs)
> > because page allocation in swap_cgroup_prepare() took too long.
> Hmm, but the page allocator makes sure to cond_resched for sleeping
> allocations. I guess what you mean is something different. It is not the
> allocation which took too look but there are too many of them and none
> of them sleeps because there is enough memory and the allocator doesn't
> sleep in that case. Right?
> > We already cond_resched when freeing page in swap_cgroup_swapoff().
> > Do the same for the page allocation.
> > 
> > Signed-off-by: Yu Zhao <>
> The patch itself makes sense to me, the changelog could see some
> clarification but other than that
> Acked-by: Michal Hocko <>

Thanks, I'll clarify the problem in the commit message and resend the

Powered by blists - more mailing lists