lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sun,  4 Jun 2017 22:44:13 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Ralf Baechle <ralf@...ux-mips.org>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-mips@...ux-mips.org,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: [PATCH] net: sched: fix mips build failure

The build of mips ar7_defconfig was failing with the error:
../net/sched/act_api.c: In function 'tcf_action_goto_chain_init':
../net/sched/act_api.c:37:18: error:
	implicit declaration of function 'tcf_chain_get'
	[-Werror=implicit-function-declaration]

../net/sched/act_api.c: In function 'tcf_action_goto_chain_fini':
../net/sched/act_api.c:45:2: error:
	implicit declaration of function 'tcf_chain_put'
	[-Werror=implicit-function-declaration]

Add two inline helpers for the case where CONFIG_NET_CLS is not enabled.

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
---

The build log of the latest linux-next is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/238623031/

 include/net/pkt_cls.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index 537d0a0..c34ade5 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -29,6 +29,17 @@ int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
 
 #else
 static inline
+struct tcf_chain *tcf_chain_get(struct tcf_block *block,
+				u32 chain_index, bool create)
+{
+	return NULL;
+}
+
+static inline void tcf_chain_put(struct tcf_chain *chain)
+{
+}
+
+static inline
 int tcf_block_get(struct tcf_block **p_block,
 		  struct tcf_proto __rcu **p_filter_chain)
 {
-- 
2.7.4

Powered by blists - more mailing lists