linux-kernel - Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17256a1e-f3a5-e6b3-ea77-064e636615dd@codeaurora.org>
Date:   Mon, 5 Jun 2017 13:23:56 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Mark Yao <mark.yao@...k-chips.com>,
        Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Carlo Caione <carlo@...one.org>,
        Kevin Hilman <khilman@...libre.com>,
        Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use
 bridge->mode_valid() callback



On 05/30/2017 03:59 PM, Philipp Zabel wrote:
> Hi Archit,
>
> On Tue, 2017-05-30 at 15:54 +0530, Archit Taneja wrote:
>> Hi,
>>
>> On 05/25/2017 07:49 PM, Jose Abreu wrote:
>>> Now that we have a callback to check if bridge supports a given mode
>>> we can use it in Synopsys Designware HDMI bridge so that we restrict
>>> the number of probbed modes to the ones we can actually display.
>>>
>>> Also, there is no need to use mode_fixup() callback as mode_valid()
>>> will handle the mode validation.
>>>
>>> NOTE: Only compile tested
>>> NOTE 2: I also had to change the pdata declaration of mode_valid
>>> custom callback so that the passed modes are const. I also changed
>>> in the platforms I found. Not even compiled it though.
>>
>> This compiles fine and has been tested on Meson by Neil.
>>
>> Since this also touches rockchip/imx drm driver files, can I get an
>> OK from the maintainers to pull the changes via drm-misc?
>
> Of course,
> Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

Thanks for the Ack.

I didn't get an ack from Rockchip, but still going ahead with
the push since it's been a while and the change is very minor.

Thanks,
Archit

>
> regards
> Philipp
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project