linux-kernel - Re: [PATCH] mfd: tc6393xb: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170605081350.oxmrhjzivarihga4@dell>
Date:   Mon, 5 Jun 2017 09:13:50 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linus.walleij@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tc6393xb: Handle return value of clk_prepare_enable

On Thu, 01 Jun 2017, Arvind Yadav wrote:

> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/mfd/tc6393xb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index d16e71b..0c9f039 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -797,7 +797,9 @@ static int tc6393xb_resume(struct platform_device *dev)
>  	int ret;
>  	int i;
>  
> -	clk_prepare_enable(tc6393xb->clk);
> +	ret = clk_prepare_enable(tc6393xb->clk);
> +	if (ret)
> +		return ret;
>  
>  	ret = tcpd->resume(dev);
>  	if (ret)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog