linux-kernel - Re: [PATCH v3 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496659200.15643.15.camel@perches.com>
Date:   Mon, 05 Jun 2017 03:40:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:     broonie@...nel.org, linus.walleij@...aro.org, gnurou@...il.com,
        robh+dt@...nel.org, tglx@...utronix.de, jason@...edaemon.net,
        alsa-devel@...a-project.org, patches@...nsource.wolfsonmicro.com,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 03/17] mfd: madera: Add common support for Cirrus
 Logic Madera codecs

On Mon, 2017-06-05 at 11:32 +0100, Lee Jones wrote:
> On Fri, 02 Jun 2017, Richard Fitzgerald wrote:
[]
> >  		if (IS_ERR(madera->reset_gpio))
> > +			ret = PTR_ERR(madera->reset_gpio);
> > +		else
> > +			ret = 0;
> 
> If you pre-initialise ret, you can drop the else.

Better to use:

		ret = PTR_ERR_OR_ZERO(madera->reset_gpio);