linux-kernel - Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170605.101957.1159360169934143154.davem@davemloft.net>
Date:   Mon, 05 Jun 2017 10:19:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     clabbe.montjoie@...il.com
Cc:     icenowy@...c.io, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com
Subject: Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure
 the EPHY is properly reseted

From: Corentin Labbe <clabbe.montjoie@...il.com>
Date: Mon, 5 Jun 2017 13:10:19 +0200

> On Mon, Jun 05, 2017 at 01:53:23AM +0800, Icenowy Zheng wrote:
>> The EPHY may be already enabled by bootloaders which have Ethernet
>> capability (e.g. current U-Boot). Thus it should be reseted properly
>> before doing the enabling sequence in the dwmac-sun8i driver, otherwise
>> the EMAC reset process may fail if no cable is plugged, and then fail
>> the dwmac-sun8i probing.
>> 
>> Tested on Orange Pi PC, One and Zero. All the boards fail to have
>> dwmac-sun8i probed with "EMAC reset timeout" without cable plugged
>> before, and with this fix they're now all able to successfully probe the
>> EMAC without cable plugged and then use the connection after a cable is
>> hot-plugged in.
>> 
>> Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i")
>> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> 
> Thanks for the fix.
> Tested-by: Corentin Labbe <clabbe.montjoie@...il.com>
> 
> Since I am the writter of the file, does I have the right to:
> Acked-by: Corentin Labbe <clabbe.montjoie@...il.com>
> or
> Reviewed-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ?

Anyone whatsoever may contribute Acked-by and Reviewed-by tags to a
patch posting.

This is all documented in Documentation/process/submitting-patches.rst